Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi-minifi/pull/45#discussion_r85137468
--- Diff:
minifi-toolkit/minifi-toolkit-configuration/src/main/java/org/apache/nifi/minifi/toolkit/configuration/ConfigMain.java
---
@@ -96,31 +102,39 @@ public int validate(String[] args) {
}
try (InputStream inputStream =
pathInputStreamFactory.create(args[1])) {
try {
- ConfigSchema configSchema =
SchemaLoader.loadConfigSchemaFromYaml(inputStream);
+ ConvertableSchema<ConfigSchema> configSchema =
SchemaLoader.loadConvertableSchemaFromYaml(inputStream);
+ boolean valid = true;
if (!configSchema.isValid()) {
+
System.out.println(FOUND_THE_FOLLOWING_ERRORS_WHEN_PARSING_THE_TEMPLATE_ACCORDING_TO_ITS_VERSION);
configSchema.getValidationIssues().forEach(s ->
System.out.println(s));
System.out.println();
- return ERR_INVALID_CONFIG;
- } else {
+ valid = false;
+ configSchema.clearValidationIssues();
+ }
+
+ ConfigSchema currentSchema = configSchema.convert();
--- End diff --
Something that's a bit confusing to the user, I had a valid v2 config file
and commented out the version line. When I did this I properly saw that there
were validation errors when validating it for it's current version (v1) but
didn't expect to see errors when "converting" it to the current version. I
completely understand why (the connection ids were not ingested) but maybe
either the second check needs to change or a third where it explicitly tries to
load it with the latest schema.
Or I could be completely off base, lol, let me know what you think.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
