Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi-minifi/pull/45#discussion_r85600674
--- Diff:
minifi-commons/minifi-commons-schema/src/main/java/org/apache/nifi/minifi/commons/schema/serialization/SchemaLoader.java
---
@@ -78,6 +80,27 @@ public static ConfigSchema
loadConfigSchemaFromYaml(Map<String, Object> yamlAsMa
public static ConvertableSchema<ConfigSchema>
loadConvertableSchemaFromYaml(Map<String, Object> yamlAsMap) throws
SchemaLoaderException {
String version =
String.valueOf(yamlAsMap.get(ConfigSchema.VERSION));
+ if (StringUtil.isNullOrEmpty(version) || String.valueOf((Object)
null).equals(version)) {
--- End diff --
@brosander what was the motivation to move all of this logging here and
potentially change which yaml version gets used? I preferred keeping the
version as a required property and assuming that null and "" were v1 (makes
things much simpler in the long run).
A side effect of the logging is weird messages when doing simple validation
or conversion using the toolkit (test.yml has no config version listed):
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
