[GitHub] nifi-minifi pull request #45: MINIFI-117 - Maintainable Configuration Versio...

[JPercivall]

Github user JPercivall commented on a diff in the pull request:

    https://github.com/apache/nifi-minifi/pull/45#discussion_r85601260
  
    --- Diff: 
minifi-toolkit/minifi-toolkit-configuration/src/main/java/org/apache/nifi/minifi/toolkit/configuration/ConfigMain.java
 ---
    @@ -336,6 +329,16 @@ public int transform(String[] args) {
             return SUCCESS;
         }
     
    +    protected void validateAndPrintIssues(ConfigSchema configSchema) {
    +        if (!configSchema.isValid()) {
    +            System.out.println("There are validation errors with the 
template, still outputting YAML but it will need to be edited.");
    +            
configSchema.getValidationIssues().forEach(System.out::println);
    --- End diff --
    
    I don't think the validation issues are getting cleared properly along the 
way:
    
    ![screen shot 2016-10-28 at 4 08 01 
pm](https://cloud.githubusercontent.com/assets/11302527/19820707/8646849c-9d28-11e6-840c-d44a5812a78e.png)
     


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---