Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi-minifi/pull/45#discussion_r85604460
--- Diff:
minifi-toolkit/minifi-toolkit-configuration/src/main/java/org/apache/nifi/minifi/toolkit/configuration/ConfigMain.java
---
@@ -336,6 +329,16 @@ public int transform(String[] args) {
return SUCCESS;
}
+ protected void validateAndPrintIssues(ConfigSchema configSchema) {
+ if (!configSchema.isValid()) {
+ System.out.println("There are validation errors with the
template, still outputting YAML but it will need to be edited.");
+
configSchema.getValidationIssues().forEach(System.out::println);
--- End diff --
Yup the first print is correct (was just including it to show what is wrong
with the config). The print out for the upgrade could be more user friendly
something like:
`
There were validation errors prior to upgrading:
<just the specified version errors>
After upgrading it has these validation errors:
<any errors after upgrading>
Any validation errors after upgrading will need to be addressed prior to
using the config.
`
In its current state it looks like the upgraded template has validation
errors for both destination ids and destination name (which should be mutually
exclusive).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
