szaszm opened a new pull request #1236:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1236
I propose that we get rid of the *StreamCallback base classes and just use
std::function to type erase the callback types where necessary. The reason is
simlicity of implementation and usage.
- `InputStreamCallback` and `OutputStreamCallback` are now aliases of
`std::function<int64_t(const std::shared_ptr<io::BaseStream>&)>`.
- `InputOutputStreamCallback` is now an alias of
`std::function<int64_t(const std::shared_ptr<io::BaseStream>&, const
std::shared_ptr<io::BaseStream>&)>`.
- `ProcessSession::read` and friends now take `const InputStreamCallback&`
and `const OutputStreamCallback&`. This means value semantics of the function
object, due to `std::function`. If the callback needs to preserve state after
the call, it needs to be passed with `std::ref(callback)`, which wraps it in a
`std::reference_wrapper<T>`.
- Introduced `ProcessSession::readBuffer` that returns the status as usual
and the buffer as `std::vector<std::byte>`.
- Replaced about a dozen callback classes with calls to
`readBuffer`/`writeBuffer`/`appendBuffer`.
- Replaced simple callback classes with inline lambdas or stream pipes.
- Converted stream pipes to use stream references instead of `shared_ptr`s,
needed in `SiteToSiteClient`
---
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA
number you are trying to resolve? Pay particular attention to the hyphen "-"
character.
- [x] Has your PR been rebased against the latest commit within the target
branch (typically main)?
- [x] Is your initial contribution a single, squashed commit?
### For code changes:
- [x] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [x] If applicable, have you updated the LICENSE file?
- [x] If applicable, have you updated the NOTICE file?
### For documentation related changes:
- [x] Have you ensured that format looks appropriate for the output in which
it is rendered?
### Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI
results for build issues and submit an update to your PR as soon as possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
