szaszm commented on a change in pull request #1236:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1236#discussion_r809187771



##########
File path: extensions/opencv/MotionDetector.cpp
##########
@@ -161,8 +160,16 @@ void MotionDetector::onTrigger(const 
std::shared_ptr<core::ProcessContext> &cont
   }
   cv::Mat frame;
 
-  opencv::FrameReadCallback cb(frame);
-  session->read(flow_file, &cb);
+  session->read(flow_file, [&frame](const std::shared_ptr<io::BaseStream>& 
inputStream) -> int64_t {

Review comment:
       Resolved most of your comments in 
[46f6a43](https://github.com/apache/nifi-minifi-cpp/pull/1236/commits/46f6a43b0843948ee7c22f79c7620bf1a2a06005).
 Feel free to reopen the threads if you have issues with the resolution, and 
thanks for the review!




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to