szaszm commented on a change in pull request #1236:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1236#discussion_r809186467
##########
File path: libminifi/include/utils/StringUtils.h
##########
@@ -402,6 +402,7 @@ class StringUtils {
return to_hex(gsl::make_span(str).as_span<const std::byte>(), uppercase);
}
+
Review comment:
This one was not an accident, I thought it separated hex/base64
functions from each other better.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
