adamdebreceni commented on a change in pull request #1237:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1237#discussion_r789487612
##########
File path: extensions/script/ExecuteScript.cpp
##########
@@ -123,6 +128,10 @@ void ExecuteScript::onTrigger(const
std::shared_ptr<core::ProcessContext> &conte
throw std::runtime_error("No script engine available");
}
+ if (module_directory_.size()) {
Review comment:
should we use `!module_directory_.empty()`?
(or better yet `std::optional<std::string>`, although I see that this member
is not a new addition)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
