[GitHub] [nifi-minifi-cpp] lordgamez commented on a change in pull request #1237: MINIFICPP-1224 Add module directory support to script execution

[GitBox]

lordgamez commented on a change in pull request #1237:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1237#discussion_r789586909



##########
File path: extensions/librdkafka/ConsumeKafka.cpp
##########
@@ -211,7 +211,7 @@ void ConsumeKafka::onSchedule(core::ProcessContext* 
context, core::ProcessSessio
   context->getProperty(DuplicateHeaderHandling.getName(), 
duplicate_header_handling_);
 
   headers_to_add_as_attributes_ = 
utils::listFromCommaSeparatedProperty(*context, 
HeadersToAddAsAttributes.getName());
-  max_poll_records_ = 
gsl::narrow<std::size_t>(utils::getOptionalUintProperty(*context, 
MaxPollRecords.getName()).value_or(DEFAULT_MAX_POLL_RECORDS));
+  max_poll_records_ = 
gsl::narrow<std::size_t>(utils::getOptionalProperty<uint64_t>(*context, 
MaxPollRecords.getName()).value_or(DEFAULT_MAX_POLL_RECORDS));

Review comment:
       I wasn't aware of this, in that case this is not needed at all, removed 
it in ddfa1b976649599300457af5d5b4100f948d6a43




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org