adamdebreceni commented on a change in pull request #1237:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1237#discussion_r789584630
##########
File path: extensions/librdkafka/ConsumeKafka.cpp
##########
@@ -211,7 +211,7 @@ void ConsumeKafka::onSchedule(core::ProcessContext*
context, core::ProcessSessio
context->getProperty(DuplicateHeaderHandling.getName(),
duplicate_header_handling_);
headers_to_add_as_attributes_ =
utils::listFromCommaSeparatedProperty(*context,
HeadersToAddAsAttributes.getName());
- max_poll_records_ =
gsl::narrow<std::size_t>(utils::getOptionalUintProperty(*context,
MaxPollRecords.getName()).value_or(DEFAULT_MAX_POLL_RECORDS));
+ max_poll_records_ =
gsl::narrow<std::size_t>(utils::getOptionalProperty<uint64_t>(*context,
MaxPollRecords.getName()).value_or(DEFAULT_MAX_POLL_RECORDS));
Review comment:
`ProcessContext::getProperty<T>(const Property&)` already returns an
`std::optional<T>`, does `getOptionalProperty` behave differently?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
