lordgamez commented on a change in pull request #1257: URL: https://github.com/apache/nifi-minifi-cpp/pull/1257#discussion_r802689109
########## File path: libminifi/include/AttributeProviderService.h ########## @@ -0,0 +1,39 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +#pragma once + +#include <string> +#include <unordered_map> +#include <vector> + +#include "core/controller/ControllerService.h" + +namespace org::apache::nifi::minifi::controllers { + +class AttributeProviderService : public core::controller::ControllerService { + public: + using ControllerService::ControllerService; + + void yield() override {} + bool isRunning() override { return getState() == core::controller::ControllerServiceState::ENABLED; } + bool isWorkAvailable() override { return false; } + + using AttributeMap = std::unordered_map<std::string, std::string>; + virtual std::vector<AttributeMap> getAttributes() = 0; Review comment: I agree with @fgerlits on this I think `AttributeMap` is cleaner in this case, and in the context of MiNiFi it is usually common knowledge that attributes consist of pairs of strings. I think `AttributeNameToValueMap` doesn't really add any new information that would justify its longer name, maps are already key-value pairs and all attributes consist of names and values. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
