szaszm commented on a change in pull request #1257: URL: https://github.com/apache/nifi-minifi-cpp/pull/1257#discussion_r802825856
########## File path: libminifi/include/AttributeProviderService.h ########## @@ -0,0 +1,39 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +#pragma once + +#include <string> +#include <unordered_map> +#include <vector> + +#include "core/controller/ControllerService.h" + +namespace org::apache::nifi::minifi::controllers { + +class AttributeProviderService : public core::controller::ControllerService { + public: + using ControllerService::ControllerService; + + void yield() override {} + bool isRunning() override { return getState() == core::controller::ControllerServiceState::ENABLED; } + bool isWorkAvailable() override { return false; } + + using AttributeMap = std::unordered_map<std::string, std::string>; + virtual std::vector<AttributeMap> getAttributes() = 0; Review comment: `AttributeNameToValueMap` wouldn't help IMO. I maintain my standpoint and I wouldn't mind the 71 character long type, but I'm fine with leaving it as is, if that's what you prefer. I might be traumatized by another codebase I used to work on, that was full of type aliases, and it hindered readability, due to constantly having to jump around. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
