mtien-apache commented on a change in pull request #5743:
URL: https://github.com/apache/nifi/pull/5743#discussion_r806129029
##########
File path:
nifi-registry/nifi-registry-core/nifi-registry-web-ui/src/main/package.json
##########
@@ -66,6 +66,7 @@
"reset-css": "4.0.1",
"roboto-fontface": "0.10.0",
"rxjs": "6.5.2",
+ "sass": "^1.49.0",
Review comment:
What is the reason for removing `node-sass` and adding `sass`?
Also, the contributors in this project typically remove `^` or `~` from
packages listed in `package.json` so that unintentional version bumps do not
occur when running `npm install`.
##########
File path:
nifi-registry/nifi-registry-core/nifi-registry-web-ui/src/main/package.json
##########
@@ -66,6 +66,7 @@
"reset-css": "4.0.1",
"roboto-fontface": "0.10.0",
"rxjs": "6.5.2",
+ "sass": "^1.49.0",
Review comment:
@ohnoitsyou that makes sense. Looks like now there is a merge conflict.
I believe latest upstream has similar changes that switch to the `sass`
package. Would you rebase on latest upstream? Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
