mtien-apache commented on a change in pull request #5743: URL: https://github.com/apache/nifi/pull/5743#discussion_r815037831
########## File path: nifi-registry/nifi-registry-core/nifi-registry-web-ui/src/main/webapp/components/explorer/dialogs/about/nf-registry-explorer-about.ts ########## @@ -0,0 +1,36 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +import { Component, Inject } from '@angular/core'; +import { MatDialog, MAT_DIALOG_DATA } from '@angular/material/dialog' + +export interface DialogData { + registryAboutVersion: string +} + +@Component({ + selector: 'nifi-registry-explorer-about-dialog', + templateUrl: './nf-registry-explorer-about.html' +}) +export class NfRegistryExplorerAbout { + /** + * NfRegistryExplorerAbout constructor. + * + * @param DialogData - The data to be injected into the dialog Review comment: Please update the doc. ```suggestion * @param data - The data to be injected into the dialog ``` ########## File path: nifi-registry/nifi-registry-core/nifi-registry-web-ui/src/main/webapp/nf-registry.html ########## @@ -79,6 +79,10 @@ <div id="nifi-registry-documentation" *ngIf="nfRegistryService.perspective !== 'login'" class="pad-right-sm"> <a matTooltip="Help" href="{{nfRegistryService.documentation.link}}" target="_blank"><i class="fa fa-question-circle help-icon" aria-hidden="true"></i></a> </div> + <button matTooltip="About" mat-ripple class="pad-right-sm" + (click)="showAboutDialog()"mat-icon-button> Review comment: ```suggestion (click)="showAboutDialog()" mat-icon-button> ``` ########## File path: nifi-registry/nifi-registry-core/nifi-registry-web-ui/src/main/webapp/components/explorer/dialogs/about/nf-registry-explorer-about.ts ########## @@ -0,0 +1,36 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +import { Component, Inject } from '@angular/core'; +import { MatDialog, MAT_DIALOG_DATA } from '@angular/material/dialog' Review comment: It doesn't look like this import is used. Please remove. ```suggestion import { MAT_DIALOG_DATA } from '@angular/material/dialog' ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
