[GitHub] [nifi] mtien-apache commented on pull request #5743: NIFI-8899 - Add NiFi Registry version information to the Registry under an "about" button.

Fri, 04 Mar 2022 13:10:11 -0800 


mtien-apache commented on pull request #5743:
URL: https://github.com/apache/nifi/pull/5743#issuecomment-1059532629


   @ohnoitsyou Thanks for the updates! Unfortunately I found a few other things.
   
   - When I click on the info icon, the circle is off-center from the icon. It 
should look more like the wrench settings icon when clicked.
   
        
![2-info-icon-circle-not-centered](https://user-images.githubusercontent.com/56892372/156839254-2b2a9bc4-f690-47fe-895b-dadf2ab42efd.png)
        
        
![3-wrench-icon-circle](https://user-images.githubusercontent.com/56892372/156839284-65543635-8fd3-4f2e-ad10-cc735316ea75.png)
   
   - In the dialog, the different states of the Close button style looks 
different than other buttons in the app. NiFi Registry follows the [NiFi Flow 
Design System (FDS)](https://nifi.apache.org/fds.html) for all of its style 
conventions. Specifically it has a `FdsDialogService` component you can 
leverage. An example of a similar button can be seen in the New Bucket dialog's 
Cancel button.
   
        <img width="415" alt="4-about-dialog" 
src="https://user-images.githubusercontent.com/56892372/156840235-5272f5d4-f0b9-42f1-9c6d-ace784adb29a.png";>
 
        
        Button state when it's clicked on:
        <img width="265" alt="5-close-dialog" 
src="https://user-images.githubusercontent.com/56892372/156840521-4c9e2163-e15c-40db-92c7-4b35a6558433.png";>
   
   - The info icon vertical alignment looks off from the question mark and 
wrench icons.
        ![Screen Shot 2022-03-04 at 1 00 00 
PM](https://user-images.githubusercontent.com/56892372/156840891-19ef65b9-3490-40d8-9d1f-3cdf596c6781.png)
   
   
   
   
   
   
   
   
   
   
     
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to