jfrazee commented on PR #5944:
URL: https://github.com/apache/nifi/pull/5944#issuecomment-1093284125
> Overall, great updates, @markap14! Using the processors felt much more
internally consistent now.
>
> I noted that while `ListAzureBlobStorage` does set the `filename`
attribute, it doesn't set it to a value that can be directly used by
`FetchAzureBlobStorage`. Instead, the `azure.blobname` contains what would be
the usable value. For example, `filename` contained `test.txt` and
`azure.blobname` contained `resources/test.txt` in my test, and it's the latter
that is needed by `FetchAzureBlobStorage`. Additionally, `path` was set to
`./`, which I think is not consistent. What do you think about setting `path`
to the value before the filename, and defaulting the `FetchAzureBlobStorage`
`Blob Name` property to `${path}/${filename}`? Not sure how this would work at
the root level, however.
>
> Same issue for the `*_12` processors. I have not exercised the ADLS
processors yet.
Oops. Overlapping replies.
`${path}/${filename}` is not inconsistent with some of the other Fetch
processors so I think it's a reasonable default. The behavior of `${path}` is
also weird enough to call broken so it'd seem ok to change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
