turcsanyip commented on code in PR #5944:
URL: https://github.com/apache/nifi/pull/5944#discussion_r877361359
##########
nifi-nar-bundles/nifi-azure-bundle/nifi-azure-processors/src/main/java/org/apache/nifi/processors/azure/storage/FetchAzureBlobStorage_v12.java:
##########
@@ -109,11 +100,11 @@ public class FetchAzureBlobStorage_v12 extends
AbstractAzureBlobProcessor_v12 {
.build();
private static final List<PropertyDescriptor> PROPERTIES =
Collections.unmodifiableList(Arrays.asList(
- STORAGE_CREDENTIALS_SERVICE,
- CONTAINER,
- BLOB_NAME,
- RANGE_START,
- RANGE_LENGTH
+ CONTAINER,
+ BLOB_NAME,
+ STORAGE_CREDENTIALS_SERVICE,
+ RANGE_START,
+ RANGE_LENGTH
Review Comment:
@markap14 indeed, moving `STORAGE_CREDENTIALS_SERVICE` down further, I
suggested in the comment, was not a good idea.
Actually, when it was placed at the first position originally, I also
followed the "What data do I want to fetch?" approach. In Azure the container
name is not globally unique (unlike bucket name on S3) but the container exists
within a Storage Account. So, for identifying the data, the user needs: Storage
Account > Container > Blob. `STORAGE_CREDENTIALS_SERVICE` contains the `Storage
Account Name`, that's why it was placed before `Container` (and also because
the credential is a property to be configured always).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
