markap14 commented on code in PR #5944:
URL: https://github.com/apache/nifi/pull/5944#discussion_r876029524
##########
nifi-nar-bundles/nifi-azure-bundle/nifi-azure-processors/src/main/java/org/apache/nifi/processors/azure/storage/ListAzureBlobStorage_v12.java:
##########
@@ -131,14 +132,14 @@ public class ListAzureBlobStorage_v12 extends
AbstractListProcessor<BlobInfo> {
.build();
private static final List<PropertyDescriptor> PROPERTIES =
Collections.unmodifiableList(Arrays.asList(
- STORAGE_CREDENTIALS_SERVICE,
- CONTAINER,
- BLOB_NAME_PREFIX,
- RECORD_WRITER,
- LISTING_STRATEGY,
- TRACKING_STATE_CACHE,
- TRACKING_TIME_WINDOW,
- INITIAL_LISTING_TARGET
+ CONTAINER,
+ LISTING_STRATEGY,
+ RECORD_WRITER,
+ STORAGE_CREDENTIALS_SERVICE,
+ BLOB_NAME_PREFIX,
+ TRACKING_STATE_CACHE,
+ TRACKING_TIME_WINDOW,
+ INITIAL_LISTING_TARGET
Review Comment:
I can agree with keeping the Blob Name Prefix with container. I do think
that should come before the credentials. I think I'd tend to put listing
strategy before credentials but honestly can go either way. But will move the
Blob Name Prefix up to colocate with container, as I regard them as both
related to one another and of equal importance.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
