fgerlits opened a new pull request, #1334: URL: https://github.com/apache/nifi-minifi-cpp/pull/1334
https://issues.apache.org/jira/browse/MINIFICPP-1803 Processor and ControllerService properties, relationships and other attributes are now static, and can be read without instantiating the class. There are 4 cases, represented by the new `ResourceType` enum: * `Processor`: a subclass of `Processor`, used to be registered using `REGISTER_RESOURCE[_AS]` * `ControllerService`: a subclass of `ControllerService`, used to be registered using `REGISTER_RESOURCE[_AS]` * `InternalResource`: a subclass of either `Processor` or `ControllerService`, used to be registered using `REGISTER_INTERNAL_RESOUCE[_AS]` * `DescriptionOnly`: used to be registered using `REGISTER_RESOURCE[_AS]`, but not a subclass of either `Processor` or `ControllerService`. Ideally, `properties()` and `relationships()` should be `constexpr` variables instead of functions, too. This will be done later as part of https://issues.apache.org/jira/browse/MINIFICPP-1825. The manifest has mostly stayed identical, with these differences: * minifi-coap: * CoapConnectorService is no longer included in the manifest. Since this controller service is marked as 'internal resource', I think this is correct. * minifi-jni: * ExecuteJavaProcessor was not included in the manifest, but now it is. I don't know why it wasn't included earlier. * The descriptions of ExecuteJavaControllerService and JavaControllerService are slightly different: I have deleted a space from the end. * minifi-mqtt: * ConvertHeartbeat, ConvertJSONAck, ConvertUpdate used to be included in the manifest, and they aren't any longer. Since these processors are marked as 'internal resource', I think this is correct. * minifi-script-extensions: * The ReloadOnScriptChange property was not included in the ExecutePythonProcessor section of the manifest. This was a bug, fixed now. * minifi-sensors: * This extension was missing from the manifest on main, not sure why. * minifi-standard-processors: * The description of ExecuteProcess is slightly different: I have added 2 missing spaces. * minifi-system: * The Battery Status Discharge property of LinuxPowerManagerService was missing from the old manifest. This was a bug, fixed now. * The description of NetworkPrioritizerService is slightly diferent: fixed typo ouput -> output. * minifi-test-processors: * The description of KamikazeProcessor is slightly diferent: fixed typo configration -> configuration. * Not sure if we should include this artifact in the manifest, but we did, so we still do. --- Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [x] Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [x] Has your PR been rebased against the latest commit within the target branch (typically main)? - [ ] Is your initial contribution a single, squashed commit? ### For code changes: - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file? - [ ] If applicable, have you updated the NOTICE file? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
