szaszm commented on code in PR #1334: URL: https://github.com/apache/nifi-minifi-cpp/pull/1334#discussion_r885502125
########## extensions/http-curl/protocols/RESTSender.cpp: ########## @@ -172,10 +167,6 @@ C2Payload RESTSender::sendPayload(const std::string url, const Direction directi } } -REGISTER_RESOURCE(RESTSender, "Encapsulates the restful protocol that is built upon C2Protocol."); +REGISTER_RESOURCE(RESTSender, DescriptionOnly); Review Comment: I didn't realize there is a third variable, whether it's included in the manifest. With that in mind, I wouldn't do complete autodetection, but rather keep the explicit declaration of "internalness". Adding an "isInternal" member could work, but leaving it as it is is fine, too. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
