fgerlits commented on code in PR #1334:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1334#discussion_r885582032
##########
extensions/aws/controllerservices/AWSCredentialsService.h:
##########
@@ -53,6 +48,25 @@ class AWSCredentialsService : public
core::controller::ControllerService {
: ControllerService(name) {
}
+ EXTENSIONAPI static constexpr const char* Description = "AWS Credentials
Management Service";
+
+ EXTENSIONAPI static const core::Property UseDefaultCredentials;
+ EXTENSIONAPI static const core::Property AccessKey;
+ EXTENSIONAPI static const core::Property SecretKey;
+ EXTENSIONAPI static const core::Property CredentialsFile;
+ static auto properties() {
+ return std::array{
+ UseDefaultCredentials,
+ AccessKey,
+ SecretKey,
+ CredentialsFile
+ };
+ }
+
+ EXTENSIONAPI static constexpr bool SupportsDynamicProperties = false;
+ EXTENSIONAPI static constexpr bool SupportsDynamicRelationships = false;
Review Comment:
Yeah, it didn't make much sense, but I didn't want to change the existing
logic.
Currently, every controller service in the manifest has a
`"supportsDynamicRelationships": false` line; should I remove that, or leave it
hard-coded to false?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
