lordgamez commented on code in PR #1348:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1348#discussion_r896784082
##########
libminifi/src/utils/Id.cpp:
##########
@@ -193,8 +189,8 @@ IdGenerator::~IdGenerator() = default;
uint64_t IdGenerator::getDeviceSegmentFromString(const std::string& str, int
numBits) const {
uint64_t deviceSegment = 0;
- for (size_t i = 0; i < str.length(); i++) {
- unsigned char c = toupper(str[i]);
+ for (auto ch : str) {
+ unsigned char c = toupper(ch);
Review Comment:
Thanks for the info, updated in da2bf0f8cc4fd4748eb075a83196de5d6fe77c66
##########
extensions/opc/src/opc.cpp:
##########
@@ -550,7 +546,7 @@ std::string OPCDateTime2String(UA_DateTime raw_date) {
int sz = snprintf(charBuf.data(), charBuf.size(), "%02hu-%02hu-%04hu
%02hu:%02hu:%02hu.%03hu", dts.day, dts.month, dts.year, dts.hour, dts.min,
dts.sec, dts.milliSec);
- return std::string(charBuf.data(), sz);
+ return {charBuf.data(), static_cast<std::size_t>(sz)};
Review Comment:
Updated in da2bf0f8cc4fd4748eb075a83196de5d6fe77c66
##########
extensions/librdkafka/KafkaConnection.cpp:
##########
@@ -125,11 +121,9 @@ void KafkaConnection::logCallback(const rd_kafka_t* rk,
int level, const char* /
case 7: // LOG_DEBUG
core::logging::LOG_DEBUG(logger) << buf;
break;
+ default:
+ throw std::runtime_error("Unknown log level: " + std::to_string(level));
Review Comment:
Updated in da2bf0f8cc4fd4748eb075a83196de5d6fe77c66
##########
extensions/coap/protocols/CoapC2Protocol.cpp:
##########
@@ -186,29 +181,30 @@ minifi::c2::Operation CoapProtocol::getOperation(int
type) const {
return minifi::c2::Operation::PAUSE;
case 9:
return minifi::c2::Operation::RESUME;
+ default:
+ return minifi::c2::Operation::ACKNOWLEDGE;
Review Comment:
Updated in da2bf0f8cc4fd4748eb075a83196de5d6fe77c66
##########
libminifi/src/c2/ControllerSocketProtocol.cpp:
##########
@@ -237,6 +233,8 @@ void
ControllerSocketProtocol::initialize(core::controller::ControllerServicePro
}
}
break;
+ default:
+ throw std::runtime_error("Unhandled operation: " +
std::to_string(head));
Review Comment:
Replaced with a log in da2bf0f8cc4fd4748eb075a83196de5d6fe77c66
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
