szaszm commented on code in PR #1348:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1348#discussion_r896806146
##########
extensions/coap/protocols/CoapC2Protocol.cpp:
##########
@@ -186,29 +181,30 @@ minifi::c2::Operation CoapProtocol::getOperation(int
type) const {
return minifi::c2::Operation::PAUSE;
case 9:
return minifi::c2::Operation::RESUME;
+ default:
+ return minifi::c2::Operation::ACKNOWLEDGE;
Review Comment:
I'm not a fan of directly calling `abort`. I just found
[`gsl_FailFast()`](https://github.com/gsl-lite/gsl-lite#contract-checking-configuration-macros),
which is meant for exactly this purpose.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
