adamdebreceni commented on code in PR #1348:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1348#discussion_r897951661
##########
libminifi/src/utils/Id.cpp:
##########
@@ -193,8 +190,8 @@ IdGenerator::~IdGenerator() = default;
uint64_t IdGenerator::getDeviceSegmentFromString(const std::string& str, int
numBits) const {
uint64_t deviceSegment = 0;
- for (size_t i = 0; i < str.length(); i++) {
- unsigned char c = toupper(str[i]);
+ for (auto ch : str) {
+ auto c = gsl::narrow<unsigned char>(std::toupper(gsl::narrow<unsigned
char>(ch)));
Review Comment:
is `gsl::narrow` the right choice here? `StringUtils` uses implicit
conversions
([cppreference](https://en.cppreference.com/w/cpp/string/byte/toupper))
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
