lordgamez commented on code in PR #1350:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1350#discussion_r907092740
##########
extensions/standard-processors/processors/ListenSyslog.cpp:
##########
@@ -86,72 +86,20 @@ void ListenSyslog::initialize() {
void ListenSyslog::onSchedule(const std::shared_ptr<core::ProcessContext>&
context, const std::shared_ptr<core::ProcessSessionFactory>&) {
gsl_Expects(context && !server_thread_.joinable() && !server_);
Review Comment:
Updated in 28faa0284cea7c53f796f27cd0effebb5d260f49
##########
extensions/standard-processors/processors/NetworkListenerProcessor.cpp:
##########
@@ -0,0 +1,78 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+#include "NetworkListenerProcessor.h"
+#include "utils/net/UdpServer.h"
+#include "utils/net/TcpServer.h"
+
+namespace org::apache::nifi::minifi::processors {
+
+NetworkListenerProcessor::~NetworkListenerProcessor() {
+ stopServer();
+}
+
+void NetworkListenerProcessor::onTrigger(const
std::shared_ptr<core::ProcessContext>&, const
std::shared_ptr<core::ProcessSession>& session) {
+ gsl_Expects(session && max_batch_size_ > 0);
+ size_t logs_processed = 0;
+ while (!server_->queueEmpty() && logs_processed < max_batch_size_) {
+ utils::net::Message received_message;
+ if (!server_->tryDequeue(received_message))
+ break;
+ transferAsFlowFile(received_message, *session);
+ ++logs_processed;
+ }
+}
+
+void NetworkListenerProcessor::startServer(
+ const core::ProcessContext& context, const core::Property&
max_batch_size_prop, const core::Property& max_queue_size_prop, const
core::Property& port_prop, utils::net::Protocol protocol) {
+ context.getProperty(max_batch_size_prop.getName(), max_batch_size_);
+ if (max_batch_size_ < 1)
+ throw Exception(PROCESS_SCHEDULE_EXCEPTION, "Max Batch Size property is
invalid");
+
+ uint64_t max_queue_size = 0;
+ context.getProperty(max_queue_size_prop.getName(), max_queue_size);
+ auto max_queue_size_opt = max_queue_size > 0 ?
std::optional<uint64_t>(max_queue_size) : std::nullopt;
+
+ int port;
+ context.getProperty(port_prop.getName(), port);
+
+ if (protocol == utils::net::Protocol::UDP) {
+ server_ = std::make_unique<utils::net::UdpServer>(max_queue_size_opt,
port, logger_);
+ } else if (protocol == utils::net::Protocol::TCP) {
+ server_ = std::make_unique<utils::net::TcpServer>(max_queue_size_opt,
port, logger_);
+ } else {
+ throw Exception(PROCESS_SCHEDULE_EXCEPTION, "Invalid protocol");
+ }
+
+ server_thread_ = std::thread([this]() { server_->run(); });
+ logger_->log_debug("Started %s server on port %d with %s max queue size and
%zu max batch size",
+ protocol.toString(),
+ port,
+ max_queue_size_opt ? std::to_string(*max_queue_size_opt)
: "no",
Review Comment:
Updated in 28faa0284cea7c53f796f27cd0effebb5d260f49
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
