lordgamez commented on code in PR #1350:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1350#discussion_r907182845
##########
extensions/standard-processors/processors/ListenSyslog.cpp:
##########
@@ -34,8 +34,8 @@ const core::Property ListenSyslog::ProtocolProperty(
core::PropertyBuilder::createProperty("Protocol")
->withDescription("The protocol for Syslog communication.")
->isRequired(true)
- ->withAllowableValues(Protocol::values())
- ->withDefaultValue(toString(Protocol::UDP))
+ ->withAllowableValues(utils::net::Protocol::values())
+ ->withDefaultValue(toString(utils::net::Protocol::UDP))
Review Comment:
Good point, I extracted the `IpProtocol` to be a common smart enum and to be
used by all utils::net components in c273419e5fce339e2808399bce2f11188448946a
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
