lordgamez commented on code in PR #1350:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1350#discussion_r907288117
##########
extensions/standard-processors/processors/ListenSyslog.cpp:
##########
@@ -53,15 +53,15 @@ const core::Property ListenSyslog::ParseMessages(
const core::Property ListenSyslog::MaxQueueSize(
core::PropertyBuilder::createProperty("Max Size of Message Queue")
->withDescription("Maximum number of Syslog messages allowed to be
buffered before processing them when the processor is triggered. "
- "If the buffer full, the message is ignored. If set
to zero the buffer is unlimited.")
- ->withDefaultValue<uint64_t>(0)->build());
+ "If the is buffer full, the message is ignored. If
set to zero the buffer is unlimited.")
Review Comment:
Good catch, fixed in 2798590a9068fcdf1061f4284f30e3454385ec0c
##########
extensions/standard-processors/processors/ListenTCP.h:
##########
@@ -0,0 +1,61 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+#pragma once
+
+#include <memory>
+#include <string>
+
+#include "NetworkListenerProcessor.h"
+#include "core/logging/LoggerConfiguration.h"
+
+namespace org::apache::nifi::minifi::processors {
+
+class ListenTCP : public NetworkListenerProcessor {
+ public:
+ explicit ListenTCP(const std::string& name, const utils::Identifier& uuid =
{})
+ : NetworkListenerProcessor(name, uuid,
core::logging::LoggerFactory<ListenTCP>::getLogger()) {
+ }
+ ListenTCP(const ListenTCP&) = delete;
+ ListenTCP(ListenTCP&&) = delete;
+ ListenTCP& operator=(const ListenTCP&) = delete;
+ ListenTCP& operator=(ListenTCP&&) = delete;
Review Comment:
Good point, updated in 2798590a9068fcdf1061f4284f30e3454385ec0c
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
