lordgamez commented on code in PR #1350:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1350#discussion_r907341601
##########
PROCESSORS.md:
##########
@@ -1279,6 +1280,24 @@ In the list below, the names of required properties
appear in bold. Any other pr
+## ListenTCP
+
+### Description
+
+Listens for incoming TCP connections and reads data from each connection using
a line separator as the message demarcator. For each message the processor
produces a single FlowFile.
+
+
+### Properties
+
+In the list below, the names of required properties appear in bold. Any other
properties (not in bold) are considered optional. The table also indicates any
default values, and whether a property supports the NiFi Expression Language.
+
+| Name | Default Value | Allowable Values |
Description
|
+|-------------------------------|---------------|------------------|-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|
+| **Listening Port** | | | The port
to listen on for communication.
|
+| **Max Batch Size** | 500 | | The
maximum number of messages to process at a time.
|
+| **Max Size of Message Queue** | 10000 | | Maximum
number of messages allowed to be buffered before processing them when the
processor is triggered. If the buffer is full, the message is ignored. If set
to zero the buffer is unlimited. |
Review Comment:
I'm not sure if we have a consensus about it. That's true that if it has a
default there will always be a value provided. I usually still mark them
required regardless of it having a default or not, if the property always needs
to have a value.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]