markap14 commented on PR #6154:
URL: https://github.com/apache/nifi/pull/6154#issuecomment-1196795533
@thenatog indeed I see the same issue in:
```
ProcessGroupsEndpointMerger
ProcessorsEndpointMerger
RemoteProcessGroupsEndpointMerger
UserGroupsEndpointMerger
UsersEndpointMerger
```
Additionally, while we are at it, IntelliJ flagged a separate issue that we
should address in the mergers.
The `RuntimeManifestEndpointMerger` has this line:
```
responseBundles.retainAll(nodeResponseBundles);
```
BUT `responseBundles` is defined as:
```
final Set<Bundle> responseBundles = responseManifest.getBundles() ==
null ? Collections.emptySet() : new
LinkedHashSet<>(responseManifest.getBundles());
```
Which means that `responseBundles` may be an immutable set. We should change
that to use ` ... == null ? new HashSet<>() : new LinkedHashSet...`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
