thenatog commented on PR #6154: URL: https://github.com/apache/nifi/pull/6154#issuecomment-1196990700
@markap14 I've incorporated your changes and tested on a cluster and I can see the entities for each node coming in now. I also have a question regarding the state vs status. My original PR changes were to update the status for the ControllerService and ReportingTask, but exceptionfactory and I were wondering if we are also supposed to be updating the state and keeping the two consistent. The suggest approach was to instead compute the state and assign that computed state to the status rather than computing both separately. I guess I wasn't sure why in some cases the state is being computed but not everywhere, for example ControllerServiceEntityMerger.java:89 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
