exceptionfactory commented on code in PR #6154:
URL: https://github.com/apache/nifi/pull/6154#discussion_r931283147
##########
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-cluster/src/main/java/org/apache/nifi/cluster/manager/ControllerServiceEntityMerger.java:
##########
@@ -36,6 +36,17 @@
public class ControllerServiceEntityMerger implements
ComponentEntityMerger<ControllerServiceEntity> {
+ @Override
+ public void merge(ControllerServiceEntity clientEntity,
Map<NodeIdentifier, ControllerServiceEntity> entityMap) {
+ ComponentEntityMerger.super.merge(clientEntity, entityMap);
+ for (Map.Entry<NodeIdentifier, ControllerServiceEntity> entry :
entityMap.entrySet()) {
+ final ControllerServiceEntity entityStatus = entry.getValue();
+ if (clientEntity != entityStatus) {
Review Comment:
This looks like it should use `clientEntity.equals()` instead of the
instance comparison.
##########
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-cluster/src/main/java/org/apache/nifi/cluster/manager/ReportingTaskEntityMerger.java:
##########
@@ -29,6 +29,17 @@
public class ReportingTaskEntityMerger implements
ComponentEntityMerger<ReportingTaskEntity> {
+ @Override
+ public void merge(ReportingTaskEntity clientEntity, Map<NodeIdentifier,
ReportingTaskEntity> entityMap) {
+ ComponentEntityMerger.super.merge(clientEntity, entityMap);
+ for (Map.Entry<NodeIdentifier, ReportingTaskEntity> entry :
entityMap.entrySet()) {
+ final ReportingTaskEntity entityStatus = entry.getValue();
+ if (clientEntity != entityStatus) {
Review Comment:
This looks like it should use clientEntity.equals() instead of the instance
comparison.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
