markap14 commented on code in PR #6154:
URL: https://github.com/apache/nifi/pull/6154#discussion_r931321801
##########
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-cluster/src/main/java/org/apache/nifi/cluster/coordination/http/endpoints/RuntimeManifestEndpointMerger.java:
##########
@@ -48,7 +49,7 @@ public NodeResponse merge(final URI uri, final String method,
final Set<NodeResp
final RuntimeManifestEntity responseEntity =
clientResponse.getClientResponse().readEntity(RuntimeManifestEntity.class);
final RuntimeManifest responseManifest =
responseEntity.getRuntimeManifest();
- final Set<Bundle> responseBundles = responseManifest.getBundles() ==
null ? Collections.emptySet() : new
LinkedHashSet<>(responseManifest.getBundles());
+ final Set<Bundle> responseBundles = responseManifest.getBundles() ==
null ? new HashSet<>() : new LinkedHashSet<>(responseManifest.getBundles());
Review Comment:
I think either is fine. I have no problem using LinkedHashSet to keep the
implementation the same.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
