adamdebreceni commented on code in PR #1447:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1447#discussion_r1018840698
##########
libminifi/include/core/ProcessSession.h:
##########
@@ -155,16 +156,25 @@ class ProcessSession : public ReferenceContainer {
std::shared_ptr<FlowFile> snapshot;
};
+ using Relationships = utils::ValueIdProvider<Relationship>;
+
+ Relationships relationships_;
Review Comment:
could be, but how we achieve a lower memory usage is not really the concern
of `ProcessSession`, this `ValueIdProvider` (rename pending) hides this away,
`id_type` could be a raw pointer, `INVALID_ID` could be redefined, and we
wouldn't have to touch `ProcessSession` for such a change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
