adam-markovics commented on code in PR #1447:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1447#discussion_r1018910021
##########
libminifi/include/core/ProcessSession.h:
##########
@@ -155,16 +156,25 @@ class ProcessSession : public ReferenceContainer {
std::shared_ptr<FlowFile> snapshot;
};
+ using Relationships = utils::ValueIdProvider<Relationship>;
+
+ Relationships relationships_;
Review Comment:
If we used raw pointers, the only member in `ValueCompressor` would be an
`unordered_set`. `compress` would become just an `insert`, `decompress` would
just become a pointer dereferencing. Is it still worth creating a class for
that, basically a wrapper around a standard container?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
