lordgamez commented on code in PR #1460:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1460#discussion_r1036007632
##########
CONFIGURE.md:
##########
@@ -119,23 +119,23 @@ for TCP and secure HTTPS communications.
name: tominifi
max concurrent tasks: 2
Properties:
- SSL Context Service: SSLServiceName
Review Comment:
Good catch, updated in cbac8731aa8f068600e1cb76a7fc0b4bdc6e72fc
##########
examples/kubernetes/daemon-set-log-collection/daemon-set-log-collection.yml:
##########
@@ -30,6 +30,7 @@ data:
nifi.provenance.repository.max.storage.time=1 MIN
nifi.provenance.repository.max.storage.size=1 MB
nifi.flowfile.repository.directory.default=${MINIFI_HOME}/flowfile_repository
+
nifi.flowfile.checkpoint.directory.default=${MINIFI_HOME}/flowfile_checkpoint
Review Comment:
Added jira ticket for this impovement:
https://issues.apache.org/jira/browse/MINIFICPP-2004
##########
examples/kubernetes/sidecar-log-collection/sidecar-log-collection.yml:
##########
@@ -32,6 +32,7 @@ data:
nifi.provenance.repository.max.storage.time=1 MIN
nifi.provenance.repository.max.storage.size=1 MB
nifi.flowfile.repository.directory.default=${MINIFI_HOME}/flowfile_repository
+
nifi.flowfile.checkpoint.directory.default=${MINIFI_HOME}/flowfile_checkpoint
Review Comment:
Added jira ticket for this impovement:
https://issues.apache.org/jira/browse/MINIFICPP-2004
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
