dan-s1 commented on PR #6689: URL: https://github.com/apache/nifi/pull/6689#issuecomment-1363956081
> Thanks for working on this new feature @dan-s1. Although most of the implementation makes sense, it raises some questions about treating blanks strings as nulls. Although the `java.net.URI` has a number of constructors, it seems like this may provide more options than necessary. There is some value in simplicity, versus exposing all the possible options, which could also avoid potential confusion related to handling blank strings as nulls. > > The discussion on NIFI-10754 originated out of issues with the `urlEncode` function. If the implementation were to be scoped down to just something like `uriEncodePath`, for instance, would that provide the desired functionality? @exceptionfactory If I understand you correctly that means there would have to be potentially two calls when constructing a URI, one to urlEncodePath and one to urlEncode to encode the parameters. I was actually intending to simplify that process of URI construction with one call which would take care of the encoding for both the path and the parameters. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
