dan-s1 commented on PR #6689: URL: https://github.com/apache/nifi/pull/6689#issuecomment-1364180293
> Thanks for clarifying the intent @dan-s1, constructing the complete URI in a single function makes sense. > > With that background, do you need all of the possible constructor options? It might be simpler to support just one or two options, as opposed to all of the convenience constructors. > That is a hard call because I am not sure what different people need. > To the other question, is there a possibility that an empty string should be allowed as an argument instead of treated as `null`? That kind of implicit conversion to `null` seems like it could create confusion, and might actually be a reason to provide a different set of supported arguments so that particular values can be `null` when passed to the `URI` constructors. Per the URI javadocs > a component of the new URI may be left undefined by passing null for the corresponding parameter. I did not see a way of explicitly passing null except if a blank string was passed. Please let me know otherwise if null can be passed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
