fgerlits commented on code in PR #1443:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1443#discussion_r1066776928


##########
extensions/standard-processors/controllers/PersistentMapStateStorage.h:
##########
@@ -22,34 +22,28 @@
 #include <memory>
 #include <utility>
 
-#include "controllers/keyvalue/AbstractAutoPersistingKeyValueStoreService.h"
-#include "UnorderedMapKeyValueStoreService.h"
+#include "controllers/keyvalue/AutoPersistor.h"
+#include "VolatileMapStateStorage.h"
 #include "core/Core.h"
 #include "properties/Configure.h"
 #include "core/logging/Logger.h"
 #include "core/logging/LoggerConfiguration.h"
 
 namespace org::apache::nifi::minifi::controllers {
 
-class UnorderedMapPersistableKeyValueStoreService : public 
AbstractAutoPersistingKeyValueStoreService,
-                                                    public 
UnorderedMapKeyValueStoreService {
+class PersistentMapStateStorage : public VolatileMapStateStorage {

Review Comment:
   I have extracted the common code to an `InMemoryKeyValueStorage` object in 
3ea9f43a15332837f1f8d4a6aeef16d9a9e201c7



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to