fgerlits commented on code in PR #1443:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1443#discussion_r1066777339
##########
extensions/rocksdb-repos/controllers/RocksDbStateStorage.cpp:
##########
@@ -219,20 +208,20 @@ bool RocksDbPersistableKeyValueStoreService::update(const
std::string& /*key*/,
throw std::logic_error("Unsupported method");
}
-bool RocksDbPersistableKeyValueStoreService::persist() {
+bool RocksDbStateStorage::persistNonVirtual() {
if (!db_) {
return false;
}
auto opendb = db_->open();
if (!opendb) {
return false;
}
- if (always_persist_) {
+ if (auto_persistor_.isAlwaysPersisting()) {
return true;
}
return opendb->FlushWAL(true /*sync*/).ok();
}
-REGISTER_RESOURCE_AS(RocksDbPersistableKeyValueStoreService,
ControllerService, ("RocksDbPersistableKeyValueStoreService",
"rocksdbpersistablekeyvaluestoreservice"));
+REGISTER_RESOURCE_AS(RocksDbStateStorage, ControllerService,
("RocksDbPersistableKeyValueStoreService",
"rocksdbpersistablekeyvaluestoreservice", "RocksDbStateStorage"));
Review Comment:
added TODO comments in 9be15ef5bc1aa512b7167c95f8633c0761b0f156
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
