fgerlits commented on code in PR #1443:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1443#discussion_r1066777841
##########
libminifi/include/controllers/keyvalue/AutoPersistor.h:
##########
@@ -16,47 +16,49 @@
*/
#pragma once
+#include <condition_variable>
+#include <memory>
+#include <mutex>
#include <string>
#include <thread>
-#include <mutex>
-#include <memory>
#include <utility>
-#include "PersistableKeyValueStoreService.h"
+#include "core/ConfigurableComponent.h"
#include "core/Core.h"
-#include "properties/Configure.h"
-#include "core/logging/Logger.h"
#include "core/logging/LoggerFactory.h"
#include "utils/Export.h"
namespace org::apache::nifi::minifi::controllers {
-class AbstractAutoPersistingKeyValueStoreService : virtual public
PersistableKeyValueStoreService {
+/**
+ * Persists in given intervals.
+ * Has an own thread, so stop() must be called before destruction of data
used by persist_.
+ */
+class AutoPersistor {
public:
- explicit AbstractAutoPersistingKeyValueStoreService(std::string name, const
utils::Identifier& uuid = {});
+ virtual ~AutoPersistor();
Review Comment:
removed the `virtual` keyword in cce6b38263a4a61352ea3f2c00a1f46a301d81f9
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
