lordgamez commented on code in PR #1502:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1502#discussion_r1100283633
##########
extensions/windows-event-log/tests/CMakeLists.txt:
##########
@@ -17,17 +17,17 @@
# under the License.
#
-set(WEL_INTEGRATION_TESTS "BookmarkTests.cpp"
"ConsumeWindowsEventLogTests.cpp" "MetadataWalkerTests.cpp")
+set(WEL_TESTS "BookmarkTests.cpp" "ConsumeWindowsEventLogTests.cpp"
"LookupCacherTests.cpp" "MetadataWalkerTests.cpp")
if (TEST_CUSTOM_WEL_PROVIDER)
execute_process(COMMAND
"${CMAKE_CURRENT_LIST_DIR}/custom-provider/generate-and-register.bat"
"${CMAKE_CURRENT_LIST_DIR}/custom-provider"
)
- list(APPEND WEL_INTEGRATION_TESTS "CWELCustomProviderTests.cpp")
+ list(APPEND WEL_TESTS "CWELCustomProviderTests.cpp")
Review Comment:
Why is `CWELCustomProviderTests` handled separately? I don't see
`TEST_CUSTOM_WEL_PROVIDER` flag set anywhere in our CI run either, could this
be run automatically or it's manual only?
##########
extensions/windows-event-log/wel/LookupCacher.h:
##########
@@ -0,0 +1,48 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+#pragma once
+
+#include <chrono>
+#include <functional>
+#include <mutex>
+#include <string>
+#include <unordered_map>
+#include <utility>
+
+namespace org::apache::nifi::minifi::wel {
+
+class LookupCacher {
Review Comment:
Should this be moved from `wel` as a more generic utility? I do not insist
if you prefer to keep it here until it is needed to be reused elsewhere.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
