[GitHub] [nifi-minifi-cpp] fgerlits commented on a diff in pull request #1502: MINIFICPP-2034 Cache the results of the username lookups in ConsumeWindowsEventLog

Mon, 13 Feb 2023 05:58:36 -0800 


fgerlits commented on code in PR #1502:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1502#discussion_r1104505787


##########
extensions/windows-event-log/tests/MetadataWalkerTests.cpp:
##########
@@ -150,10 +141,11 @@ void extractMappingsTestHelper(const std::string 
&file_name,
   REQUIRE(!input_xml.empty());
   pugi::xml_document doc;
   pugi::xml_parse_result result = doc.load_string(input_xml.c_str());
-  CHECK(result);
+  REQUIRE(result);
 
   auto regex = utils::Regex(".*Sid");
-  MetadataWalker walker(FakeWindowsEventLogMetadata{}, 
METADATA_WALKER_TESTS_LOG_NAME, update_xml, resolve, &regex);
+  auto user_id_to_username = [](const std::string& user_id) { return 
utils::OsUtils::userIdToUsername(user_id); };
+  MetadataWalker walker(FakeWindowsEventLogMetadata{}, 
METADATA_WALKER_TESTS_LOG_NAME, update_xml, resolve, &regex, 
user_id_to_username);

Review Comment:
   you're right, it isn't -- I have removed it in 
db3bda60234fcdb1d37aa53f1184b58fce4a2207



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to