szaszm commented on code in PR #1502:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1502#discussion_r1105977434
##########
extensions/windows-event-log/ConsumeWindowsEventLog.cpp:
##########
@@ -173,6 +174,13 @@ const core::Property
ConsumeWindowsEventLog::ProcessOldEvents(
withDescription("This property defines if old events (which are created
before first time server is started) should be processed.")->
build());
+const core::Property ConsumeWindowsEventLog::CacheUsernameLookups(
+ core::PropertyBuilder::createProperty("Cache Username Lookups")->
Review Comment:
I would rename this to identifier lookups or SID lookups, because SIDs can
represent usernames and groups alike.
from [Microsoft
docs](https://learn.microsoft.com/en-us/windows-server/identity/ad-ds/manage/understand-security-identifiers):
> A security identifier is used to uniquely identify a security principal or
security group. Security principals can represent any entity that can be
authenticated by the operating system, such as a user account, a computer
account, or a thread or process that runs in the security context of a user or
computer account.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
