martinzink commented on code in PR #1501:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1501#discussion_r1102496393
##########
libminifi/include/Connection.h:
##########
@@ -52,86 +53,81 @@ class Connection : public core::Connectable {
const utils::Identifier &srcUUID, const
utils::Identifier &destUUID);
explicit Connection(std::shared_ptr<core::Repository> flow_repository,
std::shared_ptr<core::ContentRepository> content_repo,
std::shared_ptr<SwapManager> swap_manager,
std::string name, const utils::Identifier& uuid);
- // Destructor
~Connection() override = default;
- // Set Source Processor UUID
+ Connection(const Connection &parent) = delete;
+ Connection &operator=(const Connection &parent) = delete;
+
+ static constexpr uint64_t DEFAULT_BACKPRESSURE_SIZE_THRESHOLD = 10000;
+ static constexpr uint64_t DEFAULT_BACKPRESSURE_DATA_THRESHOLD = 10_MB;
Review Comment:
Good idea :+1: , I've renamed them in
https://github.com/apache/nifi-minifi-cpp/pull/1501/commits/8cfacbd1bd5916c7366bbee7e6d86fa916b9d38d
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]