szaszm commented on code in PR #1501:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1501#discussion_r1105968470
##########
libminifi/include/Connection.h:
##########
@@ -58,8 +58,8 @@ class Connection : public core::Connectable {
Connection(const Connection &parent) = delete;
Connection &operator=(const Connection &parent) = delete;
- static constexpr uint64_t DEFAULT_BACKPRESSURE_SIZE_THRESHOLD = 10000;
- static constexpr uint64_t DEFAULT_BACKPRESSURE_DATA_THRESHOLD = 10_MB;
+ static constexpr uint64_t DEFAULT_BACKPRESSURE_THRESHOLD_COUNT = 10000;
+ static constexpr uint64_t DEFAULT_BACKPRESSURE_THRESHOLD_DATA_SIZE = 10_MB;
Review Comment:
I think we can cut the count in half, but increase the data size at least
10x, to 100 MB. Those defaults would be more reasonable in most cases IMO.
```suggestion
static constexpr uint64_t DEFAULT_BACKPRESSURE_THRESHOLD_COUNT = 5000;
static constexpr uint64_t DEFAULT_BACKPRESSURE_THRESHOLD_DATA_SIZE =
100_MB;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
