martinzink commented on code in PR #1504: URL: https://github.com/apache/nifi-minifi-cpp/pull/1504#discussion_r1108201009
########## cmake/MiNiFiOptions.cmake: ########## @@ -102,9 +101,8 @@ add_minifi_option(ENABLE_SQL "Enables the SQL Suite of Tools." ON) add_minifi_option(ENABLE_MQTT "Enables the mqtt extension." OFF) add_minifi_option(ENABLE_PCAP "Enables the PCAP extension." OFF) add_minifi_option(ENABLE_LIBRDKAFKA "Enables the librdkafka extension." ON) -add_minifi_option(ENABLE_SCRIPTING "Enables the scripting extensions." OFF) add_minifi_option(ENABLE_LUA_SCRIPTING "Enables lua scripting" OFF) -add_minifi_option(DISABLE_PYTHON_SCRIPTING "Disables python scripting" OFF) +add_minifi_option(ENABLE_PYTHON_SCRIPTING "Enables python scripting" OFF) Review Comment: There was ENABLE_PYTHON which controlled the python bindings in nanofi. We didnt really use that one so I've removed the whole nanofi-python bindings entirely. Prior to this PR, there was ENABLE_SCRIPTING which was OFF by default, and there was two additional flags namely DISABLE_PYTHON_SCRIPTING(OFF), ENABLE_LUA_SCRIPTING(OFF), which only mattered if the ENABLE_SCRIPTING was ON. Instead of this I've added ENABLE_PYTHON_SCRIPTING ~(ENABLE_SCRIPTING && NOT DISABLE_PYTHON_SCRIPTING) and ENABLE_LUA_SCRIPTING ~(ENABLE_SCRIPTING && ENABLE_LUA_SCRIPTING), so long story short by default both lua and python was disabled and they still are disabled by default. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
