martinzink commented on code in PR #1504:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1504#discussion_r1112900303
##########
bootstrap.sh:
##########
@@ -263,9 +263,8 @@ add_option HTTP_CURL_ENABLED ${TRUE} "DISABLE_CURL"
add_option LIBARCHIVE_ENABLED ${TRUE} "DISABLE_LIBARCHIVE"
add_dependency LIBARCHIVE_ENABLED "libarchive"
-add_option EXECUTE_SCRIPT_ENABLED ${FALSE} "ENABLE_SCRIPTING"
-add_dependency EXECUTE_SCRIPT_ENABLED "python"
-add_dependency EXECUTE_SCRIPT_ENABLED "lua"
+add_option PYTHON_SCRIPTING_ENABLED ${FALSE} "ENABLE_PYTHON_SCRIPTING"
+add_option LUA_SCRIPTING_ENABLED ${FALSE} "ENABLE_LUA_SCRIPTING"
Review Comment:
Exactly like this (except that we dont have native/custom lua processors yet)
ExecuteScript processor lives in libminifi-script-extension.so
(ENABLE_LUA_SCRIPTING || ENABLE_PYTHON_SCRIPTING)
Custom python processors and the PythonScriptExecutor live in
libminifi-python-script-extension.so (ENABLE_PYTHON_SCRIPTING)
And the LuaScriptExecutor lives in libminifi-lua-script-extensions.so
(ENABLE_LUA_SCRIPTING),
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
