mtien-apache commented on code in PR #7117:
URL: https://github.com/apache/nifi/pull/7117#discussion_r1158927643
##########
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/jquery/propertytable/jquery.propertytable.js:
##########
@@ -2001,6 +2021,43 @@
propertyData.setItems([]);
};
+ /**
+ * Gets all the referenced parameters from the {parameterContext} based on
the value of {parameterReference} with matching {sensitive} property
+ *
+ * @param {string} parameterReference
+ * @param {ParameterContextEntity} parameterContext
+ * @param {boolean} sensitive
+ * @returns {ParameterEntity[]}
+ */
+ var getExistingParametersReferenced = function (parameterReference,
parameterContext, sensitive) {
+ var parameters = _.get(parameterContext.component, 'parameters', []);
+ var existingParametersReferenced = [];
+
+ if (!_.isNil(parameterReference) && !_.isEmpty(parameters)) {
+ // can't use from common/constants because we are modifying the
lastIndex below
+ var paramRefsRegex = /#{(')?([a-zA-Z0-9-_. ]+)\1}/gm;
Review Comment:
@exceptionfactory It's not necessary to define a separate capturing group
for `'`. I updated this block of code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
