mtien-apache commented on code in PR #7117:
URL: https://github.com/apache/nifi/pull/7117#discussion_r1173203769
##########
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/jquery/propertytable/jquery.propertytable.js:
##########
@@ -2261,9 +2319,32 @@
* @argument {object} properties The properties
* @argument {map} descriptors The property descriptors
(property name -> property descriptor)
* @argument {map} history
+ * @argument {object} options
*/
- loadProperties: function (properties, descriptors, history) {
- return this.each(function () {
+ loadProperties: function (properties, descriptors, history, options) {
+ var self = this;
+ var groupId = null;
+
+ var loadParameterContext = function (options) {
+ if (typeof options.getFullParameterContextDeferred ===
'function') {
Review Comment:
@exceptionfactory I added additional comments for the `options` argument.
The `options` would only be necessary when `loadProperties` is called from
processor configurations because it requires access to a parameter context in
order to reference parameters. `loadProperties` can be called from other parts
of NiFi, such as the Controller Service or Reporting Task that don't require
additional options. In order to know this was called from processor configs, we
can check for the parameter context options.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
