exceptionfactory commented on code in PR #7117:
URL: https://github.com/apache/nifi/pull/7117#discussion_r1164840506
##########
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/jquery/propertytable/jquery.propertytable.js:
##########
@@ -2001,6 +2020,45 @@
propertyData.setItems([]);
};
+ /**
+ * Gets all the referenced parameters from the {parameterContext} based on
the value of {parameterReference} with matching {sensitive} property
+ *
+ * @param {string} parameterReference
+ * @param {ParameterContextEntity} parameterContext
+ * @param {boolean} sensitive
+ * @returns {ParameterEntity[]}
+ */
+ var getExistingParametersReferenced = function (parameterReference,
parameterContext, sensitive) {
Review Comment:
Is there a reason for passing `parameterContext` and `sensitive` as
arguments? It looks like `sensitive` is always `false` and `parameterContext`
always references `currentParameterContext`. Unless there is some other reason
to keep them, it seems like the implementation could be simplified.
##########
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/jquery/propertytable/jquery.propertytable.js:
##########
@@ -2261,9 +2319,32 @@
* @argument {object} properties The properties
* @argument {map} descriptors The property descriptors
(property name -> property descriptor)
* @argument {map} history
+ * @argument {object} options
*/
- loadProperties: function (properties, descriptors, history) {
- return this.each(function () {
+ loadProperties: function (properties, descriptors, history, options) {
+ var self = this;
+ var groupId = null;
+
+ var loadParameterContext = function (options) {
+ if (typeof options.getFullParameterContextDeferred ===
'function') {
Review Comment:
Is there a particular reason for passing `getFullParameterContextDeferred`
and `getParameterContext` as properties of the `options` argument? Could they
be passed as specific arguments instead of properties of `options`? If there is
some other reason, recommend at least providing additional comments for the
`options` argument.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
